Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fast case conversion and comparison #670

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fast case conversion and comparison #670

merged 1 commit into from
Dec 18, 2024
+123 −9

Conversation

lihuiba
Copy link
Collaborator

@lihuiba lihuiba commented Dec 17, 2024 •
edited
Loading

comparison is 4+ times faster on MBP M1:

[ RUN      ] tolowerupper.perf_strncasecmp
[       OK ] tolowerupper.perf_strncasecmp (3270 ms)
[ RUN      ] tolowerupper.perf_photon__stricmp
[       OK ] tolowerupper.perf_photon__stricmp (777 ms)

@lihuiba lihuiba requested a review from Coldwings December 17, 2024 13:13
@lihuiba lihuiba force-pushed the to_lower_upper branch 2 times, most recently from 4f54ae2 to 0083d6d Compare December 17, 2024 14:45
Coldwings
Coldwings approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@Coldwings Coldwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lihuiba lihuiba merged commit 040d8a9 into alibaba:main Dec 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Coldwings Coldwings Coldwings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lihuiba @Coldwings