Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

超时设置的线程重入问题修复 #314

Merged
merged 2 commits into from
Apr 7, 2024
Merged

Conversation

DQinYuan
Copy link
Collaborator

#294

将 timeout 设置到 RunEnvironment 对象的属性中, 每个 environment 自己维护自己的超时, 嵌套调用时可以避免相互冲突。

com.ql.util.express.RunEnvironment#executeTimeOut

@DQinYuan DQinYuan requested a review from pymBupt February 25, 2024 08:50
Copy link
Collaborator

@pymBupt pymBupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment

src/main/java/com/ql/util/express/ExecuteTimeOut.java Outdated Show resolved Hide resolved
return executeTimeOut != null && executeTimeOut.isExpired();
}

public ExecuteTimeOut getExecuteTimeOut() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getExecuteTimeOut > getExecuteTimeout

import com.ql.util.express.InstructionSetContext;
import com.ql.util.express.OperateData;
import com.ql.util.express.RunEnvironment;
import com.ql.util.express.*;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

阿里的开发规约不建议使用import *

src/main/java/com/ql/util/express/ExecuteTimeOut.java Outdated Show resolved Hide resolved
@DQinYuan DQinYuan requested a review from pymBupt March 31, 2024 06:50
@DQinYuan DQinYuan mentioned this pull request Mar 31, 2024
Copy link
Collaborator

@pymBupt pymBupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@DQinYuan DQinYuan merged commit f21cb5d into master Apr 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants