Skip to content

fix(rocklet): skip kata dind setup when docker data-root cannot be created #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhongwen666 merged 1 commit into from
Aug 6, 2026
Merged

fix(rocklet): skip kata dind setup when docker data-root cannot be created #1309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions rock/rocklet/local_files/docker_run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,27 @@ setup_kata_dind() {
docker_root="$custom_root"
fi
fi
mkdir -p "$docker_root"
for i in $(seq 0 7); do
mknod -m 660 /dev/loop$i b 7 $i 2>/dev/null || true
done
mount -o loop /docker-disk.img "$docker_root"
mount -o remount,rw /sys/fs/cgroup
mount -o remount,rw /proc/sys
# Directory creation requires write and execute permissions on the nearest existing parent.
if [ ! -d "$docker_root" ]; then
local nearest_existing_path="$docker_root"
while [ ! -e "$nearest_existing_path" ]; do
nearest_existing_path=$(dirname "$nearest_existing_path")
done
if [ ! -d "$nearest_existing_path" ] || [ ! -w "$nearest_existing_path" ] || [ ! -x "$nearest_existing_path" ]; then
echo "Warning: no permission to create Docker data root '$docker_root'; skipping Kata DinD setup." >&2
else
mkdir -p "$docker_root"
fi
fi

if [ -d "$docker_root" ]; then
for i in $(seq 0 7); do
mknod -m 660 /dev/loop$i b 7 $i 2>/dev/null || true
done
mount -o loop /docker-disk.img "$docker_root"
mount -o remount,rw /sys/fs/cgroup
mount -o remount,rw /proc/sys
fi
}

# Run rocklet
Expand Down Expand Up @@ -88,4 +102,4 @@ else
# glibc-based distributions
mkdir -p "${LOG_DIR}"
/tmp/miniforge/bin/rocklet --port ${port} >> "${LOG_DIR}/rocklet_uvicorn.log" 2>&1
fi
fi
Loading