Skip to content

fix(scheduler): report image prune failures (#995) - #1333

Open
014-code wants to merge 1 commit into
alibaba:masterfrom
014-code:fix/scheduler-prune-observability
Open

fix(scheduler): report image prune failures (#995)#1333
014-code wants to merge 1 commit into
alibaba:masterfrom
014-code:fix/scheduler-prune-observability

Conversation

@014-code

Copy link
Copy Markdown

Summary

  • Preserve the exit codes of docker image prune and docker builder prune.
  • Mark an ImageCleanupTask worker as failed when either prune command fails.
  • Keep docuum startup and existing daemon behavior non-blocking when prune fails.

Issue

Fixes #995

Tests

  • Added coverage for Docker prune command failures and failed worker reporting while docuum is already running.
  • Passed: .venv\Scripts\python.exe -m pytest tests/unit/admin/scheduler/test_image_cleanup_task.py tests/unit/admin/scheduler/test_task_base.py -q (28 passed)
  • Passed: uvx ruff check rock/admin/scheduler/tasks/image_cleanup_task.py tests/unit/admin/scheduler/test_image_cleanup_task.py
  • Passed: uvx ruff format --check rock/admin/scheduler/tasks/image_cleanup_task.py tests/unit/admin/scheduler/test_image_cleanup_task.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] fix(scheduler): ImageCleanupTask silently skips dangling/BuildKit prune after first run

1 participant