feat: trace/watch/stack/monitor method-pattern 特殊字符增加等号(=)和点号(.)

实际操作等号(=)和点号(.)更友好
alibaba · Oct 27, 2023 · b96eb91 · b96eb91
1 parent 44adc44
commit b96eb91
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/core/src/main/java/com/taobao/arthas/core/command/monitor200/AbstractMethodBasedCommand.java b/core/src/main/java/com/taobao/arthas/core/command/monitor200/AbstractMethodBasedCommand.java
@@ -30,8 +30,8 @@ public void setMethodPattern(final String methodPattern) {
 
     @Override
     protected void enhance(final CommandProcess process) {
-        if ("~".equals(methodPattern)) { //smart way
-          final Pattern smartPattern = Pattern.compile("([.][A-Z][^.]*)([.:])([a-z][^. ]*)$");
+        if ("=".equals(methodPattern) || "~".equals(methodPattern) || ".".equals(methodPattern)) { //smart way
+          final Pattern smartPattern = Pattern.compile("([.][A-Z][^.]*)([.: ]+)([a-z][^. ]*)$");
           final Matcher matcher = smartPattern.matcher(classPattern);
           if (matcher.find()) {
               methodPattern = matcher.group(3);

diff --git a/core/src/main/java/com/taobao/arthas/core/command/monitor200/MonitorCommand.java b/core/src/main/java/com/taobao/arthas/core/command/monitor200/MonitorCommand.java
@@ -22,8 +22,8 @@
 @Summary("Monitor method execution statistics, e.g. total/success/failure count, average rt, fail rate, etc. ")
 @Description("\nExamples:\n" +
         "  monitor org.apache.commons.lang.StringUtils isBlank\n" +
-        "  monitor org.apache.commons.lang.StringUtils.isBlank ~\n" +
-        "  monitor org.apache.commons.lang.StringUtils:isBlank ~\n" +
+        "  monitor org.apache.commons.lang.StringUtils.isBlank =\n" +
+        "  monitor org.apache.commons.lang.StringUtils:isBlank =\n" +
         "  monitor org.apache.commons.lang.StringUtils isBlank -c 5\n" +
         "  monitor org.apache.commons.lang.StringUtils isBlank params[0]!=null\n" +
         "  monitor -b org.apache.commons.lang.StringUtils isBlank params[0]!=null\n" +

diff --git a/core/src/main/java/com/taobao/arthas/core/command/monitor200/StackCommand.java b/core/src/main/java/com/taobao/arthas/core/command/monitor200/StackCommand.java
@@ -23,8 +23,8 @@
 @Summary("Display the stack trace for the specified class and method")
 @Description(Constants.EXPRESS_DESCRIPTION + Constants.EXAMPLE +
         "  stack org.apache.commons.lang.StringUtils isBlank\n" +
-        "  stack org.apache.commons.lang.StringUtils.isBlank ~\n" +
-        "  stack org.apache.commons.lang.StringUtils:isBlank ~\n" +
+        "  stack org.apache.commons.lang.StringUtils.isBlank =\n" +
+        "  stack org.apache.commons.lang.StringUtils:isBlank =\n" +
         "  stack *StringUtils isBlank\n" +
         "  stack *StringUtils isBlank params[0].length==1\n" +
         "  stack *StringUtils isBlank '#cost>100'\n" +

diff --git a/core/src/main/java/com/taobao/arthas/core/command/monitor200/TraceCommand.java b/core/src/main/java/com/taobao/arthas/core/command/monitor200/TraceCommand.java
@@ -31,8 +31,8 @@
 @Summary("Trace the execution time of specified method invocation.")
 @Description(value = Constants.EXPRESS_DESCRIPTION + Constants.EXAMPLE +
         "  trace org.apache.commons.lang.StringUtils isBlank\n" +
-        "  trace org.apache.commons.lang.StringUtils.isBlank ~\n" +
-        "  trace org.apache.commons.lang.StringUtils:isBlank ~\n" +
+        "  trace org.apache.commons.lang.StringUtils.isBlank =\n" +
+        "  trace org.apache.commons.lang.StringUtils:isBlank =\n" +
         "  trace *StringUtils isBlank\n" +
         "  trace *StringUtils isBlank params[0].length==1\n" +
         "  trace *StringUtils isBlank '#cost>100'\n" +

diff --git a/core/src/main/java/com/taobao/arthas/core/command/monitor200/WatchCommand.java b/core/src/main/java/com/taobao/arthas/core/command/monitor200/WatchCommand.java
@@ -22,8 +22,8 @@
 @Summary("Display the input/output parameter, return object, and thrown exception of specified method invocation")
 @Description(Constants.EXPRESS_DESCRIPTION + "\nExamples:\n" +
         "  watch org.apache.commons.lang.StringUtils isBlank\n" +
-        "  watch org.apache.commons.lang.StringUtils.isBlank ~\n" +
-        "  watch org.apache.commons.lang.StringUtils:isBlank ~\n" +
+        "  watch org.apache.commons.lang.StringUtils.isBlank =\n" +
+        "  watch org.apache.commons.lang.StringUtils:isBlank =\n" +
         "  watch org.apache.commons.lang.StringUtils isBlank '{params, target, returnObj, throwExp}' -x 2\n" +
         "  watch *StringUtils isBlank params[0] params[0].length==1\n" +
         "  watch *StringUtils isBlank params '#cost>100'\n" +