Grpc web proxy #2668
Merged
Grpc web proxy #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hengyunabc
reviewed
Sep 21, 2023
arthas-grpc-web-proxy/pom.xml
Outdated
| <url>https://github.com/alibaba/arthas</url> | ||
| <properties> | ||
| <java.version>1.8</java.version> | ||
| <netty.version>4.1.92.Final</netty.version> |
There was a problem hiding this comment.
在parent pom.xml 里已经有 netty version相关，不需要重复定义
hengyunabc
reviewed
Sep 21, 2023
arthas-grpc-web-proxy/pom.xml
Outdated
| </dependency> | ||
| <dependency> | ||
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> |
|
Pair 类可以改用 |
|
jdk 11 测试跑失败了。可能要加这个依赖 <dependency>
<groupId>javax.annotation</groupId>
<artifactId>javax.annotation-api</artifactId>
<scope>provided</scope>
<optional>true</optional>
</dependency> |
|
已按照要求更新pom |
hengyunabc
reviewed
Sep 21, 2023
arthas-grpc-web-proxy/src/main/java/com/taobao/arthas/grpcweb/proxy/util/IOUtils.java
Outdated
Show resolved
Hide resolved
hengyunabc
reviewed
Sep 21, 2023
arthas-grpc-web-proxy/src/test/java/com/taobao/arthas/grpcweb/proxy/server/startGrpcTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add grpc web proxy server module