Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remove the field writer which only differ in first character that one is upper case the other is lower case #3222

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yanxutao89
Copy link
Collaborator

What this PR does / why we need it?

fix remove the field writer which only differ in first character that one is upper case the other is lower case

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.66%. Comparing base (f6cdd54) to head (fdb4e06).
Report is 58 commits behind head on main.

Files with missing lines Patch % Lines
.../alibaba/fastjson2/writer/ObjectWriterCreator.java 55.55% 1 Missing and 3 partials ⚠️
...ibaba/fastjson2/writer/ObjectWriterCreatorASM.java 66.66% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3222      +/-   ##
============================================
- Coverage     74.27%   72.66%   -1.61%     
+ Complexity    23542    22865     -677     
============================================
  Files           659      668       +9     
  Lines         91870    92079     +209     
  Branches      20539    20509      -30     
============================================
- Hits          68238    66912    -1326     
- Misses        15240    16591    +1351     
- Partials       8392     8576     +184     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wenshao
Copy link
Member

wenshao commented Dec 27, 2024

没有单测?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants