Allow project to build with Java 17 and 21 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The formatting changes and a result of the new version of Google Java Format being used, which in turn is needed for spotless to build on Java 17 and 21. This change makes no guarantee that project actually runs on 17 or 21, so it's only a very small first step
geoand
force-pushed
the
build-on-java-17-21
branch
from
ecdd129 to
5e5d379
Compare
8 tasks
|
Hi @geoand thanks for the contribution! Supporting Java 17 and 21 is a high priority in our roadmap. I just created #203 to track the long-term Java 17 support. Besides, in order to merge this pull request, we may need to wait for #204 to allow Java8 can still build success with higher spotless version and add build checks for Java 17. |
|
Totally understood! Thanks for providing that feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatting changes and a result of the new version of Google Java Format being used, which in turn
is needed for spotless to build on Java 17 and 21.
This change makes no guarantee that project actually runs on 17 or 21, so it's only a very small first step