Skip to content

fix(react): fix some render issue in non web browser environment #4335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wenchiangh wants to merge 1 commit into
base: formily_next
Choose a base branch
from
+39 −4
Open

fix(react): fix some render issue in non web browser environment #4335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 39 additions & 4 deletions packages/react/src/shared/render.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,36 +6,71 @@ interface Env {
createPortal?: (children: ReactNode, container: Element) => ReactPortal
}

const createPortalDOM = () => {
try {
// env.portalDOM work with env.createPortal
if (!env.createPortal) {
return
}

// environment not support div element
// @ts-ignore
if (typeof globalThisPolyfill?.HTMLDivElement !== 'function') {
return
}

env.portalDOM ??= globalThisPolyfill?.document?.createElement?.('div')
} catch (error) {
// do nothing
}
}

const env: Env = {
portalDOM: globalThisPolyfill?.document?.createElement?.('div'),
portalDOM: undefined,
createPortal: globalThisPolyfill?.['ReactDOM']?.createPortal,
}

createPortalDOM()

/* istanbul ignore next */
const loadCreatePortal = () => {
if (!env.createPortal) {
try {
// eslint-disable-next-line @typescript-eslint/no-var-requires
env.createPortal ??= require('react-dom')?.createPortal
createPortalDOM()
} catch {}
}
if (!env.createPortal) {
try {
// @ts-ignore
import('react-dom')
.then((module) => (env.createPortal ??= module?.createPortal))
.then((module) => {
env.createPortal ??= module?.createPortal
createPortalDOM()
})
.catch()
} catch {}
}
}

// test template element is supported in current environment
const supportsTemplate =
// @ts-ignore
typeof globalThisPolyfill?.HTMLTemplateElement === 'function' &&
// @ts-ignore
'content' in globalThisPolyfill?.HTMLTemplateElement?.prototype

export const render = (element: React.ReactElement) => {
if (globalThisPolyfill.navigator?.product === 'ReactNative') return null
if (globalThisPolyfill?.navigator?.product === 'ReactNative') return null

if (env.portalDOM && env.createPortal) {
return env.createPortal(element, env.portalDOM)
} else {
} else if (supportsTemplate) {
return React.createElement('template', {}, element)
}

return null
}

loadCreatePortal()
Loading