-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cohere embedding for ai-cache #1572
Conversation
上一个搞乱了一些东西,故重开 |
@ayanami-desu 麻烦签署一下 CLA,然后文件有一些冲突,麻烦fix一下 |
冲突解决了 |
@@ -82,11 +76,11 @@ func (c *ProviderConfig) Validate() error { | |||
if c.typ == "" { | |||
return errors.New("embedding service type is required") | |||
} | |||
initializer, has := providerInitializers[c.typ] | |||
_, has := providerInitializers[c.typ] | |||
if !has { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个判定方法是不是需要改一下,直接判断 c.initializer
就行了吧?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1572 +/- ##
==========================================
+ Coverage 35.91% 43.50% +7.59%
==========================================
Files 69 76 +7
Lines 11576 12325 +749
==========================================
+ Hits 4157 5362 +1205
+ Misses 7104 6627 -477
- Partials 315 336 +21 |
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #1449
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
docker-compose.yml
envoy.yaml
Ⅴ. Special notes for reviews