Skip to content

feat: support retry on http status code#1817

Merged
johnlanni merged 7 commits intoalibaba:mainfrom
cr7258:retry-on-status-code
Mar 11, 2025
Merged

feat: support retry on http status code#1817
johnlanni merged 7 commits intoalibaba:mainfrom
cr7258:retry-on-status-code

Conversation

@cr7258
Copy link
Copy Markdown
Collaborator

@cr7258 cr7258 commented Feb 25, 2025

Ⅰ. Describe what this PR did

新增 retryOnStatus []string 参数支持基于请求的 http 状态码来配置是否需要重试,支持通过正则表达式的方式匹配 http 状态吗。

Ⅱ. Does this pull request fix one issue?

fixes #1808

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@cr7258 cr7258 requested review from CH3CHO and rinfx as code owners February 25, 2025 14:07
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni
Copy link
Copy Markdown
Collaborator

@cr7258 Please resolve the conflicts

@cr7258 cr7258 force-pushed the retry-on-status-code branch from 260fdf2 to d725f24 Compare February 26, 2025 13:24
Comment thread plugins/wasm-go/extensions/ai-proxy/README.md Outdated
@cr7258 cr7258 requested a review from johnlanni February 27, 2025 02:05
Copy link
Copy Markdown
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 19496e5 into alibaba:main Mar 11, 2025
VinceCui pushed a commit to VinceCui/higress that referenced this pull request May 21, 2025
Co-authored-by: Kent Dong <ch3cho@qq.com>
ink-hz pushed a commit to ink-hz/higress-ai-capability-auth that referenced this pull request Nov 5, 2025
Co-authored-by: Kent Dong <ch3cho@qq.com>
ISADBA pushed a commit to ISADBA/higress that referenced this pull request Jan 13, 2026
Co-authored-by: Kent Dong <ch3cho@qq.com>
ISADBA pushed a commit to ISADBA/higress that referenced this pull request Jan 13, 2026
Co-authored-by: Kent Dong <ch3cho@qq.com>
johnlanni pushed a commit that referenced this pull request Jan 31, 2026
Co-authored-by: Kent Dong <ch3cho@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ai-proxy 插件希望能支持基于请求的 http 状态码来配置是否需要重试

4 participants