Skip to content

Set the llm-api-key field of the ai-search plugin to optional#1846

Merged
johnlanni merged 1 commit intoalibaba:mainfrom
johnlanni:set-llm-api-key-optional
Mar 3, 2025
Merged

Set the llm-api-key field of the ai-search plugin to optional#1846
johnlanni merged 1 commit intoalibaba:mainfrom
johnlanni:set-llm-api-key-optional

Conversation

@johnlanni
Copy link
Copy Markdown
Collaborator

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@johnlanni johnlanni requested review from CH3CHO and rinfx as code owners March 3, 2025 12:41
@johnlanni johnlanni changed the title set llm-api-key field optional of ai-search plugin Set the llm-api-key field of the ai-search plugin to optional Mar 3, 2025
@johnlanni johnlanni merged commit 0905cd0 into alibaba:main Mar 3, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.41%. Comparing base (ef31e09) to head (147ed35).
Report is 330 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1846      +/-   ##
==========================================
+ Coverage   35.91%   43.41%   +7.50%     
==========================================
  Files          69       76       +7     
  Lines       11576    12301     +725     
==========================================
+ Hits         4157     5340    +1183     
+ Misses       7104     6628     -476     
- Partials      315      333      +18     

see 71 files with indirect coverage changes

VinceCui pushed a commit to VinceCui/higress that referenced this pull request May 21, 2025
ink-hz pushed a commit to ink-hz/higress-ai-capability-auth that referenced this pull request Nov 5, 2025
ISADBA pushed a commit to ISADBA/higress that referenced this pull request Jan 13, 2026
ISADBA pushed a commit to ISADBA/higress that referenced this pull request Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants