Skip to content

feat: add mcpServer in config map #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2025
Merged

Conversation

Jing-ze
Copy link
Collaborator

@Jing-ze Jing-ze commented Mar 26, 2025

Ⅰ. Describe what this PR did

add mcpServer in config map

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

add unit test

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@Jing-ze Jing-ze self-assigned this Mar 26, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.29126% with 123 lines in your changes missing coverage. Please review.

Project coverage is 43.24%. Comparing base (ef31e09) to head (dd799e2).
Report is 375 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ingress/kube/configmap/mcp_server.go 40.59% 117 Missing and 3 partials ⚠️
pkg/ingress/kube/configmap/controller.go 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (40.29%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1953      +/-   ##
==========================================
+ Coverage   35.91%   43.24%   +7.32%     
==========================================
  Files          69       79      +10     
  Lines       11576    12685    +1109     
==========================================
+ Hits         4157     5485    +1328     
+ Misses       7104     6858     -246     
- Partials      315      342      +27     
Files with missing lines Coverage Δ
pkg/ingress/kube/configmap/config.go 80.00% <100.00%> (+1.42%) ⬆️
pkg/ingress/kube/configmap/controller.go 0.00% <0.00%> (ø)
pkg/ingress/kube/configmap/mcp_server.go 40.59% <40.59%> (ø)

... and 72 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 87fe1ae into alibaba:main Mar 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants