Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for array as event parameter in useEventListener #2598

Merged
merged 7 commits into from
Aug 21, 2024

Conversation

askwuxue
Copy link
Contributor

@askwuxue askwuxue commented Jul 12, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#2434

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English support for array as event parameter in useEventListener
🇨🇳 Chinese useEventListener 事件入参支持数组

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link
Collaborator

@crazylxr crazylxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外再加一个使用例子

packages/hooks/src/useEventListener/index.ts Outdated Show resolved Hide resolved
@askwuxue
Copy link
Contributor Author

另外再加一个使用例子

已补充

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ askwuxue
❌ crazylxr
You have signed the CLA already but the status is still pending? Let us recheck it.

@crazylxr
Copy link
Collaborator

LGTM

@crazylxr crazylxr merged commit eb700b9 into alibaba:master Aug 21, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants