feat: useStorage expirationTime #2672
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jobyrao
reviewed
Mar 2, 2025
| if (expirationTime) { | ||
| if (parsed.timestamp && Date.now() - parsed.timestamp > expirationTime) { | ||
| storage?.removeItem(key); | ||
| return undefined; |
There was a problem hiding this comment.
would it be more reasonable to return defaultValue here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
希望 useLocalStorageState 可以支持自定义过期时间
Close #2659
Test
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge