Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useVirtualList-getVisibleCount在fromIndex===list.lenght时导致endIndex初始化异常,返回负值 #2683

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Eferinte
Copy link

@Eferinte Eferinte commented Nov 27, 2024

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

如果最后一个元素的高度大于容器高度,getOffset方法会返回list.length;当此值作为getVisibleCount的fromIndex参数时,由于for循环条件会略过endIndex的更新,导致getVisibleCount返回负值;

💡 需求背景和解决方案

--

📝 更新日志

语言 更新描述
🇺🇸 英文 fix- when the last item higher than the container, useVirtualList will return [];
🇨🇳 中文 fix- 最后一个元素高度大于容器时,useVirtualList返回空数组;

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档无须补充
  • 代码演示无须提供
  • TypeScript 定义无须补充
  • Changelog 无须提供

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2024

CLA assistant check
All committers have signed the CLA.

@Eferinte Eferinte changed the title fix: getVisibleCount在fromIndex===list.lenght时导致endIndex初始化异常,返回负值 fix: useVirtualList-getVisibleCount在fromIndex===list.lenght时导致endIndex初始化异常,返回负值 Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants