refactor sls client manager #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
henryzhx8
commented
Dec 10, 2024
•
henryzhx8
commented
- 废除了原sdk目录，原目录下的部分函数分别转移到其它地方，原有调用点全部做相应调整：
- Client与创建请求相关的移到SLSClientManager和FlusherSLS中，其余全部移到内部的EnterpriseSLSClientManager
- Common工具函数移到SLSConstant、SLSUtil、common/http/Constant、common/HashUtil、common/EndcodingUtil
- Result工具函数移到SLSReponse
- CurImp废除，功能由common/http/Curl替代
- FlusherSLS的Init和BuildRequest进行了调整，适配新的机制
| message LogtailBufferMeta | ||
| { | ||
| required string project = 1; | ||
| required string endpoint = 2; | ||
| required string region = 2; |
There was a problem hiding this comment.
这个没有，只是改了pb的名字，pb的string里面是不带这个信息的
| @@ -14,9 +14,45 @@ | |||
|
|
|||
| #include "common/http/HttpRequest.h" | |||
|
|
|||
| DEFINE_FLAG_INT32(default_http_request_timeout_secs, "", 15); | |||
| DEFINE_FLAG_INT32(default_http_request_timeout_sec, "", 15); | |||
There was a problem hiding this comment.
外部不用的参数？
这个原则可能得明确下。这些参数是否希望用户修改？
There was a problem hiding this comment.
这个是新加参数，后缀名统一都改成sec结尾，不存在兼容问题。目前现行的操作都是通过gflag引入，避免出现之前超时截断把时间写死后期发现不妥无法调整的问题。
yyuuttaaoo
reviewed
Dec 26, 2024
henryzhx8
force-pushed
the
feat/client
branch
from
cf21533 to
bc0cd0d
Compare
yyuuttaaoo
approved these changes
Dec 30, 2024
messixukejia
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.