feat(context-menu): prevent event bubbling when "menus" is empty

alibaba · Jan 30, 2024 · 1a68807 · 1a68807
1 parent dfe6878
commit 1a68807
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/shell/src/components/context-menu.tsx b/packages/shell/src/components/context-menu.tsx
@@ -34,7 +34,7 @@ export function ContextMenu({ children, menus, pluginContext }: {
     );
   }
 
-  if (!menus || !menus.length) {
+  if (!menus) {
     return (
       <>{ children }</>
     );
@@ -53,6 +53,9 @@ export function ContextMenu({ children, menus, pluginContext }: {
 }
 
 ContextMenu.create = (pluginContext: IPublicModelPluginContext, menus: IPublicTypeContextMenuAction[], event: MouseEvent) => {
+  event.preventDefault();
+  event.stopPropagation();
+
   const children: React.ReactNode[] = parseContextMenuAsReactNode(parseContextMenuProperties(menus, {
     pluginContext,
   }), {