Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support nacos #266

Merged
merged 7 commits into from
Dec 26, 2024
Merged

support nacos #266

merged 7 commits into from
Dec 26, 2024

Conversation

123liuziming
Copy link
Collaborator

related to #228

@123liuziming 123liuziming changed the title support nacos [WIP] support nacos Dec 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 75.14793% with 42 lines in your changes missing coverage. Please review.

Project coverage is 80.02%. Comparing base (4262fe6) to head (f516a99).

Files with missing lines Patch % Lines
...g/inst-api-semconv/instrumenter/rpc/rpc_metrics.go 75.89% 18 Missing and 9 partials ⚠️
.../instrumenter/experimental/nacos_client_metrics.go 46.42% 10 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
- Coverage   82.36%   80.02%   -2.35%     
==========================================
  Files          20       23       +3     
  Lines         845      976     +131     
==========================================
+ Hits          696      781      +85     
- Misses        122      156      +34     
- Partials       27       39      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@123liuziming 123liuziming changed the title [WIP] support nacos support nacos Dec 26, 2024
@123liuziming 123liuziming merged commit 753a609 into main Dec 26, 2024
9 checks passed
@123liuziming 123liuziming deleted the feat/nacos branch December 26, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants