Skip to content

fix: add traffic-type label to distinguish pass type, fix #501#502

Open
qshuai wants to merge 2 commits intoalibaba:masterfrom
qshuai:feature-traffic-type
Open

fix: add traffic-type label to distinguish pass type, fix #501#502
qshuai wants to merge 2 commits intoalibaba:masterfrom
qshuai:feature-traffic-type

Conversation

@qshuai
Copy link
Copy Markdown

@qshuai qshuai commented Jan 16, 2023

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 16, 2023

CLA assistant check
All committers have signed the CLA.

@sczyh30 sczyh30 added the area/metrics Issue related to metrics and monitoring label Jan 17, 2023
@sczyh30
Copy link
Copy Markdown
Member

sczyh30 commented Jan 17, 2023

Hi, could you please sign the CLA here: https://cla-assistant.io/alibaba/sentinel-golang?pullRequest=502

@qshuai
Copy link
Copy Markdown
Author

qshuai commented Jan 17, 2023

Hi, could you please sign the CLA here: https://cla-assistant.io/alibaba/sentinel-golang?pullRequest=502

done

jnan806
jnan806 previously approved these changes Jan 17, 2023
Copy link
Copy Markdown
Contributor

@jnan806 jnan806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qshuai

This PR only distinguish TrafficType inbound / outbound.

but issue #501 request to distinguish circuitbreak / flow

image

@qshuai
Copy link
Copy Markdown
Author

qshuai commented Jan 17, 2023

@qshuai

This PR only distinguish TrafficType inbound / outbound.

but issue #501 request to distinguish circuitbreak / flow

image

好的,我想这个地方有个前提假设:inbound block的流量往往和限流有关,而outbound block流量和熔断有关。

Comment thread core/stat/stat_slot.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/metrics Issue related to metrics and monitoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants