upgrade to clang17

alibaba · Oct 31, 2023 · 8d3cbfd · 8d3cbfd
1 parent 0082545
commit 8d3cbfd
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 5 deletions.
diff --git a/.github/workflows/bazel.yml b/.github/workflows/bazel.yml
@@ -14,10 +14,16 @@ jobs:
     steps:
       - uses: actions/checkout@v2
 
+      - name: Install newer Clang
+        run: |
+          wget https://apt.llvm.org/llvm.sh
+          chmod +x ./llvm.sh
+          sudo ./llvm.sh 17
+
       - name: Build
         working-directory: ${{github.workspace}}
-        run: bazel build --action_env=CXX=clang++ --action_env=CC=clang ...
+        run: bazel build --action_env=CXX=clang++-17 --action_env=CC=clang-17 ...
 
       - name: Test
         working-directory: ${{github.workspace}}
-        run: bazel test --action_env=CXX=clang++ --action_env=CC=clang --test_output=errors ...
+        run: bazel test --action_env=CXX=clang++-17 --action_env=CC=clang-17 --test_output=errors ...
diff --git a/.github/workflows/ubuntu_clang.yml b/.github/workflows/ubuntu_clang.yml
@@ -75,6 +75,12 @@ jobs:
       - name: Install ninja-build tool
         uses: seanmiddleditch/gha-setup-ninja@v3
 
+      - name: Install newer Clang
+        run: |
+          wget https://apt.llvm.org/llvm.sh
+          chmod +x ./llvm.sh
+          sudo ./llvm.sh 17
+
       - name: Check protoc
         run: protoc --version
 
@@ -87,7 +93,7 @@ jobs:
           CXX=clang++ CC=clang 
           cmake -B ${{github.workspace}}/build -G Ninja \
                 -DCMAKE_BUILD_TYPE=${{matrix.mode}} -DBUILD_WITH_LIBCXX=${{matrix.libcxx}} -DENABLE_SSL=${{matrix.ssl}} \
-                -DUSE_CCACHE=${{env.ccache}} -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++\
+                -DUSE_CCACHE=${{env.ccache}} -DCMAKE_C_COMPILER=clang-17 -DCMAKE_CXX_COMPILER=clang++-17\
                 -DBUILD_CORO_HTTP=OFF -DBUILD_CORO_IO=OFF -DBUILD_CORO_RPC=OFF -DBUILD_EASYLOG=OFF -DBUILD_STRUCT_JSON=OFF -DBUILD_STRUCT_XML=OFF -DBUILD_STRUCT_YAML=OFF -DBUILD_UTIL=OFF
       - name: Build
         run: cmake --build ${{github.workspace}}/build --config ${{matrix.mode}}

diff --git a/src/struct_pb/conformance/CMakeLists.txt b/src/struct_pb/conformance/CMakeLists.txt
@@ -1,7 +1,7 @@
 set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/output/tests/struct_pb)
 find_package(Protobuf QUIET)
 if (NOT Protobuf_FOUND)
-    message(WARNING "to build struct_pb conformance test, you must install libprotoc first!!!")
+    message(STATUS "to build struct_pb conformance test, you need to install libprotoc first")
     return()
 endif ()
 set(CMAKE_INCLUDE_CURRENT_DIR ON)

diff --git a/src/struct_pb/protoc-plugin/CMakeLists.txt b/src/struct_pb/protoc-plugin/CMakeLists.txt
@@ -11,7 +11,7 @@ if (Protobuf_FOUND)
         RUNTIME DESTINATION bin
     )
 else ()
-    message(WARNING "struct_pb is skipped. To build struct_pb protoc plugin, you must install libprotoc first!!!\n"
+    message(STATUS "struct_pb is skipped. To build struct_pb protoc plugin, you need to install libprotoc first\n"
             "see https://alibaba.github.io/yalantinglibs/en/struct_pb/struct_pb_generating_your_struct.html"
             )
 endif ()