[struct_pack][fix] fix warning (#751)

alibaba · Aug 13, 2024 · dfcb5d5 · dfcb5d5
1 parent e6a51b8
commit dfcb5d5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
@@ -72,7 +72,7 @@ jobs:
         with:
           key: ${{ github.job }}-${{ matrix.mode}}-arch-${{ matrix.arch}}
       - name: Configure CMake
-        run: cmake -B ${{github.workspace}}\build -G Ninja -DCMAKE_BUILD_TYPE=${{ matrix.mode }} -DYLT_ENABLE_SSL=${{matrix.ssl}} -DBUILD_STRUCT_PB=OFF -DUSE_CCACHE=ON -DENABLE_CPP_20=OFF
+        run: cmake -B ${{github.workspace}}\build -G Ninja -DCMAKE_BUILD_TYPE=${{ matrix.mode }} -DYLT_ENABLE_SSL=${{matrix.ssl}} -DBUILD_STRUCT_PB=OFF -DUSE_CCACHE=ON
       - name: Build
         run: cmake --build ${{github.workspace}}\build
       - name: Test

diff --git a/cmake/build.cmake b/cmake/build.cmake
@@ -18,6 +18,10 @@ if (has_cxx_std_20)
         if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 10)
             set(has_cxx_std_20 FALSE)
         endif()
+    elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
+        if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 1930)
+            set(has_cxx_std_20 FALSE)
+        endif()
     endif()
 endif()