-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
call coro_rpc function return bool failed crossplatform #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en rpc return bool type
Code Coverage Report
|
yangxingpping
changed the title
fix get_func_name return values are different on windows and linux wh…
call coro_rpc function return bool failed crossplatform
Feb 25, 2024
LGTM |
Code Coverage Report
|
The code format has some problem, after fix it i will merge it. |
Code Coverage Report
|
Code Coverage Report
|
poor-circle
reviewed
Feb 25, 2024
Code Coverage Report
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
call rpc function which return bool failed when rpc server and rpc client are run at different OS(Windows,Linux).
Why
close bug #607
modify get_func_name function implement, when return string include windows function call style reference in https://learn.microsoft.com/en-us/cpp/cpp/stdcall?view=msvc-170, remove the function call style string.
What is changing
function get_func_name implement
Example