[Version Bump Configuration]add configure version in hpp file #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Code Coverage Report |
PikachuHyA
reviewed
Mar 11, 2024
CMakeLists.txt
Outdated
|
|
||
| configure_file( | ||
| ${PROJECT_SOURCE_DIR}/include/ylt/ylt.hpp.in | ||
| ${PROJECT_SOURCE_DIR}/include/ylt/ylt.hpp |
There was a problem hiding this comment.
It might be better to put the genereated files in the build folder.
There was a problem hiding this comment.
Any example for generated file?
There was a problem hiding this comment.
use PROJECT_BINARY_DIR and adjust include path too
configure_file(
${PROJECT_SOURCE_DIR}/include/ylt/ylt.hpp.in
${PROJECT_BINARY_DIR}/include/ylt/ylt.hpp
There was a problem hiding this comment.
There was a problem hiding this comment.
use
PROJECT_BINARY_DIRand adjust include path tooconfigure_file( ${PROJECT_SOURCE_DIR}/include/ylt/ylt.hpp.in ${PROJECT_BINARY_DIR}/include/ylt/ylt.hpp
Put it in binray dir will make users confused since they can not fond any clues about generated files.
Actullay it's SOURCE FILES definitely.
|
I think we can reference asio:https://github.com/chriskohlhoff/asio/blob/master/asio/include/asio/version.hpp It's more easier to maintain, only upgrade the version file when release a version. |
poor-circle
reviewed
Mar 12, 2024
Did you mean rename them in version.h |
|
Code Coverage Report |
|
Code Coverage Report |
It's easy to do this, but branch name and commmit id might not be generated dynamically? |
|
Code Coverage Report |
|
If use cmake to generate the version file, when the user copy ylt headers and include the header and include version.hpp will cause error, because the file is not exist. I think just ceate a version.hpp to the include directory is ok, don't need cmake. |
poor-circle
force-pushed
the
cmake-configure-version-in
branch
from
1d25cb7
to
19325d1
Compare
|
Code Coverage Report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Users can get ylt version from header file and specific package with git hash might help us to locate detail branch and commit id.
What is changing
Example