Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coro_http]fix chunked and remote address #665

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

qicosmos
Copy link
Collaborator

Why

fix:

  • http client request chunked don't set status;
  • fix http server remote address

What is changing

Example

Copy link

Code Coverage Report
for detail, goto summary download Artifacts

Filename                                          Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
coro_io/channel.hpp                                      14                 0   100.00%         105                 3    97.14%          30                 2    93.33%
coro_io/client_pool.hpp                                  28                 0   100.00%         354                40    88.70%         118                35    70.34%
coro_io/coro_file.hpp                                    22                 2    90.91%         213                46    78.40%          56                21    62.50%
coro_io/coro_io.hpp                                      50                 1    98.00%         319                11    96.55%           6                 1    83.33%
coro_io/detail/client_queue.hpp                          10                 1    90.00%          47                 1    97.87%          10                 1    90.00%
coro_io/io_context_pool.hpp                              34                 3    91.18%         206                19    90.78%          26                 6    76.92%
coro_io/rate_limiter.hpp                                 13                 1    92.31%          85                 9    89.41%           8                 3    62.50%
coro_rpc/impl/common_service.hpp                          3                 0   100.00%          55                 0   100.00%          26                 7    73.08%
coro_rpc/impl/context.hpp                                 8                 0   100.00%         101                 6    94.06%          16                 6    62.50%
coro_rpc/impl/coro_connection.hpp                        45                10    77.78%         454                74    83.70%         112                37    66.96%
coro_rpc/impl/coro_rpc_client.hpp                        40                 5    87.50%         508                77    84.84%         122                45    63.11%
coro_rpc/impl/coro_rpc_server.hpp                        20                 1    95.00%         237                36    84.81%          80                35    56.25%
coro_rpc/impl/errno.h                                    14                 4    71.43%          58                40    31.03%          34                17    50.00%
coro_rpc/impl/protocol/coro_rpc_protocol.hpp              9                 1    88.89%         101                32    68.32%          24                 9    62.50%
coro_rpc/impl/protocol/struct_pack_protocol.hpp           3                 0   100.00%          14                 0   100.00%           0                 0         -
coro_rpc/impl/router.hpp                                 22                 0   100.00%         221                13    94.12%          26                13    50.00%
coro_rpc/impl/rpc_execute.hpp                             3                 0   100.00%         172                 0   100.00%           4                 1    75.00%
easylog.hpp                                              17                 0   100.00%          73                 3    95.89%          14                 5    64.29%
easylog/appender.hpp                                     23                 0   100.00%         274                18    93.43%          90                26    71.11%
easylog/record.hpp                                       18                 0   100.00%         125                14    88.80%          16                 2    87.50%
struct_pack.hpp                                          35                 2    94.29%         320                28    91.25%          34                14    58.82%
struct_pack/alignment.hpp                                 9                 9     0.00%         136               136     0.00%           0                 0         -
struct_pack/calculate_size.hpp                           21                 5    76.19%         405                81    80.00%          32                 7    78.12%
struct_pack/compatible.hpp                                6                 0   100.00%           9                 0   100.00%           6                 2    66.67%
struct_pack/derived_helper.hpp                           14                 7    50.00%         127                61    51.97%           6                 3    50.00%
struct_pack/endian_wrapper.hpp                            9                 3    66.67%         152                28    81.58%           2                 1    50.00%
struct_pack/error_code.hpp                               11                 6    45.45%          38                30    21.05%           0                 0         -
struct_pack/foreach_macro.h                               1                 0   100.00%           1                 0   100.00%           0                 0         -
struct_pack/md5_constexpr.hpp                            27                 3    88.89%         174                18    89.66%          32                 1    96.88%
struct_pack/packer.hpp                                   23                 2    91.30%         495                20    95.96%          48                 9    81.25%
struct_pack/reflection.hpp                               16                 9    43.75%        1343               630    53.09%         514               251    51.17%
struct_pack/size_info.hpp                                 2                 0   100.00%          10                 0   100.00%           0                 0         -
struct_pack/trivial_view.hpp                              4                 0   100.00%          10                 0   100.00%           0                 0         -
struct_pack/tuple.hpp                                    21                 2    90.48%          54                 4    92.59%           6                 3    50.00%
struct_pack/type_calculate.hpp                           37                30    18.92%         753               576    23.51%           0                 0         -
struct_pack/type_id.hpp                                   4                 4     0.00%         277               277     0.00%           0                 0         -
struct_pack/unpacker.hpp                                 50                 5    90.00%        1296               141    89.12%         212                89    58.02%
struct_pack/user_helper.hpp                               6                 0   100.00%          63                 2    96.83%           2                 1    50.00%
struct_pack/util.h                                       12                 7    41.67%         105                61    41.90%           2                 0   100.00%
struct_pack/varint.hpp                                   23                 3    86.96%         147                14    90.48%          12                 3    75.00%
util/concurrentqueue.h                                   79                19    75.95%        1256               567    54.86%         292               148    49.32%
util/dragonbox.h                                         90                50    44.44%         735               388    47.21%          38                34    10.53%
util/dragonbox_to_chars.h                                 6                 1    83.33%         440               365    17.05%          54                43    20.37%
util/expected.hpp                                        94                 8    91.49%         256                40    84.38%          44                13    70.45%
util/function_name.h                                      2                 1    50.00%          22                 7    68.18%           0                 0         -
util/magic_names.hpp                                      1                 1     0.00%          56                56     0.00%           0                 0         -
util/meta_string.hpp                                     10                 3    70.00%          46                23    50.00%           8                 0   100.00%
util/time_util.h                                         21                12    42.86%         184               119    35.33%          26                 5    80.77%
util/type_traits.h                                        1                 0   100.00%           9                 0   100.00%           0                 0         -

Files which contain no functions:
struct_pack/marco.h                                       0                 0         -           0                 0         -           0                 0         -
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                  1031               221    78.56%       12641              4114    67.46%        2188               899    58.91%

@qicosmos qicosmos merged commit a7716ea into alibaba:main Apr 24, 2024
33 checks passed
@qicosmos qicosmos deleted the fix_chunked branch April 24, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant