Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: with MSVC, SP_LIKELY takes no effect #696

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix: with MSVC, SP_LIKELY takes no effect #696

merged 1 commit into from
Jun 21, 2024

Commits on Jun 21, 2024

  1. [struct_pack] update rule for enabling [[likely]] 

    MSVC intentionally defined __cplusplus to 199711L, ignoring the actual standard, hence MACRO definitions of `SP_LIKELY` and `SP_UNLIKELY` go to wrong branches in MSVC build.
    @scuzqy
    scuzqy committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    6b1182d View commit details
    Browse the repository at this point in the history