Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metric] fix summary serialize to json thread-safe #778

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[metric] fix summary serialize to json thread-safe #778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions include/ylt/metric/summary.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,22 +240,23 @@ class basic_dynamic_summary : public dynamic_metric {
#ifdef CINATRA_ENABLE_METRIC_JSON
virtual void serialize_to_json(std::string& str) override {
json_summary_t summary{name_, help_, std::string(metric_name())};

for (auto& [labels_value, summary_value] : label_quantile_values_) {
json_summary_metric_t metric;
double sum = 0;
uint64_t count = 0;
auto rates = summary_value->stat(sum, count);
metric.count = count;
metric.sum = sum;
for (size_t i = 0; i < quantiles_.size(); i++) {
for (size_t i = 0; i < labels_value.size(); i++) {
metric.labels[labels_name_[i]] = labels_value[i];
{
std::lock_guard guard(mutex_);
for (auto& [labels_value, summary_value] : label_quantile_values_) {
json_summary_metric_t metric;
double sum = 0;
uint64_t count = 0;
auto rates = summary_value->stat(sum, count);
metric.count = count;
metric.sum = sum;
for (size_t i = 0; i < quantiles_.size(); i++) {
for (size_t i = 0; i < labels_value.size(); i++) {
metric.labels[labels_name_[i]] = labels_value[i];
}
metric.quantiles.emplace(quantiles_[i], rates[i]);
}
metric.quantiles.emplace(quantiles_[i], rates[i]);
summary.metrics.push_back(std::move(metric));
}

summary.metrics.push_back(std::move(metric));
}
iguana::to_json(summary, str);
}
Expand Down
Loading