Skip to content

chore: clean up redundant access specifiers in hnsw_sparse#62

Closed
SYaoJun wants to merge 2 commits intoalibaba:mainfrom
SYaoJun:public_0204
Closed

chore: clean up redundant access specifiers in hnsw_sparse#62
SYaoJun wants to merge 2 commits intoalibaba:mainfrom
SYaoJun:public_0204

Conversation

@SYaoJun
Copy link
Contributor

@SYaoJun SYaoJun commented Feb 4, 2026

Hi zvec team, I read the code in the hnsw_sparse directory and found some clang-tidy warnings about redundant class access specifiers (public and private). Would you consider adding the readability-redundant-access-specifiers check to .clang-tidy?

@SYaoJun
Copy link
Contributor Author

SYaoJun commented Feb 4, 2026

Hi @Cuiyus, I'm encountering a CI failure related to running Ruff Linter. Do you know how to fix it?

@Cuiyus
Copy link
Collaborator

Cuiyus commented Feb 5, 2026

Thank you for your contribution. Zvec also plans to incorporate clang-tidy checks. The "readability-redundant-access-specifiers" issue you mentioned will be taken into consideration.

Furthermore, for the failures caused by the Ruff Linter check, I did not observe them in the current PR's CI. They should have been fixed in the commit #59.

@Cuiyus
Copy link
Collaborator

Cuiyus commented Feb 5, 2026

We have grouped the private member functions in one section and the private data members in another section. This arrangement is in line with the current code style design of zvec. We believe that this code organization method will enhance the readability and maintainability of the code.

@SYaoJun
Copy link
Contributor Author

SYaoJun commented Feb 5, 2026

We have grouped the private member functions in one section and the private data members in another section. This arrangement is in line with the current code style design of zvec. We believe that this code organization method will enhance the readability and maintainability of the code.

OK. Glad to confirm your design intent; I'll close this PR.

@SYaoJun SYaoJun closed this Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants