fix mouse for camera controller #2566
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
force-pushed
the
fix/qt67mouse
branch
from
0841652
to
04ee7f8
Compare
This fixes all the "Injection of parameters into signal handlers is deprecated. Use JavaScript functions with formal parameters instead." warnings.
Qt3D.Extras cannot be updated to 2.6 yet, otherwise there are errors.
With Qt6, OpenGL is not used directly anymore, and we thus must use the RHI backend, set to version 1.0. The SphericalHarmonics shaders, which were previously written in OpenGL, need to be updated accordingly.
Call the `QGeometry` objects from the correct module, and initialize correctly the Camera object upon the construction of the TrackballController object.
Additionally harmonize comments and explicitly declare parameters for slots that need them.
`PointSize` is not supported by RHI.
The fit must be automatically triggered when the size of the image changes. In case the image size remains the same but the orientation tag is updated, this means that the displayed size of the image has changed (with the orientation taken into account, the width and height might end up being inverted), so the fit should also be triggered.
Disable and hide the wireframe mode as the shaders need to be updated for RHI.
When converting the `StatusData` to a dictionary, only data attributes should be stored in said dictionary. With Qt6, the `objectNameChanged` signal, of type `SignalInstance`, is added to the dictionary. It needs to be removed manually as it is not JSON-serializable. Otherwise, the nodes cannot be computed anymore.
Replace `DiffuseSpecularMaterial`, which does not seem to support correctly textures anymore, with `DiffuseMapMaterial`.
`QtQuick.Window` does not exist anymore with Qt6. QQuickWindow is now directly part of the QtQuick module.
This prevents crashes when the project is done loading but `Application` is not yet ready.
QMouseEvent::x() and QMouseEvent::y() have been marked as deprecated and should be replaced with QMouseEvent::position().x() and QMouseEvent::position().y().
The curve scale of the mouse area for an edge used to be defined when initializing the `EdgeMouseArea` for that edge. Setting it triggers a chain of event that allow the mouse area to be active, thus correctly detecting when it is being hovered or clicked on. With Qt6, these events unfolded before the `EdgeMouseArea` had finished initializing, which then caused it to not be active until the edge's shape was modified (and the chain of events triggered again). It is now set once the component has been created, so all the events can happen in an environment where they are taken into account.
The callbacks of `childrenRepeater` (which was used to "fill" `ListAttributes` with children) were not correctly set. Their prototypes were missing the `index` argument, meaning that instead of being provided with the child attribute that was added or deleted, they were provided with its index in the model. The added children attributes were also instatiated as empty attribute pins that were still visible, thus increasing indirectly the spacing of the initial pin.
cbentejac
force-pushed
the
fix/qt67mouse
branch
from
04ee7f8
to
d1fddf2
Compare
fabiencastan
requested changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason, the logicaldevice does not work on qt 6.7 with the mouse.
This PR will avoid the problem by using another approach