Skip to content

fix: remove async from void onPress callback (SonarCloud bug) #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alichherawalla wants to merge 2 commits into
base: main
Choose a base branch
from

fix: add .catch() to handle removeServer promise rejection

489ebc8
Select commit
Loading
Failed to load commit list.
Open

fix: remove async from void onPress callback (SonarCloud bug) #174

fix: add .catch() to handle removeServer promise rejection
489ebc8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 14, 2026 in 0s

86.44% (target 80.00%)

View this Pull Request on Codecov

86.44% (target 80.00%)

Details

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.44%. Comparing base (17dbf25) to head (489ebc8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/screens/RemoteServersScreen.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   86.46%   86.44%   -0.02%     
==========================================
  Files         214      214              
  Lines       10515    10516       +1     
  Branches     2818     2819       +1     
==========================================
- Hits         9092     9091       -1     
- Misses        772      773       +1     
- Partials      651      652       +1
Files with missing lines Coverage Δ
src/screens/RemoteServersScreen.tsx 84.21% <50.00%> (-1.13%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov