Skip to content

Localize process kill and list copy#34

Open
jerryfan wants to merge 1 commit into
aliou:mainfrom
jerryfan:localize-process-kill-list-copy
Open

Localize process kill and list copy#34
jerryfan wants to merge 1 commit into
aliou:mainfrom
jerryfan:localize-process-kill-list-copy

Conversation

@jerryfan
Copy link
Copy Markdown

@jerryfan jerryfan commented May 2, 2026

This keeps the process-control path English by default, but makes the highest-risk user-facing copy optionally localizable.

Why these strings:

  • kill results include terminate/failure/timeout guidance, where wording affects whether a user force-kills the right process.
  • list output is the quick status surface for deciding what is still running, failed, or killed.
  • I avoided broader UI/help/docs wrapping so this stays reviewable and easy to revert.

What changed:

  • adds a tiny optional i18n bridge with English fallbacks
  • adds es/fr/pt-BR bundles for the kill/list status path
  • preserves current behavior when no i18n provider is present
  • avoids generated files and package/dependency changes

Validation:

  • npx tsc --noEmit passed
  • npx biome check --write src/i18n.ts src/index.ts src/tools/actions/kill.ts src/tools/actions/list.ts passed
  • npx vitest run ran; 4 passed, 14 failed on this Windows checkout because tests cannot resolve a shell executable for process-spawn tests

If useful later, I’m happy to handle broader localization in small follow-up PRs using whatever locale set you prefer.

@aliou
Copy link
Copy Markdown
Owner

aliou commented May 4, 2026

hey @jerryfan ! I'm in the process of rewriting the extension to decouple the process management from the ui in pi, so this or might become irrelevant in not too long. I'll keep it open for now and ping you when this refactor lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants