Localize process kill and list copy#34
Open
jerryfan wants to merge 1 commit into
Open
Conversation
Owner
|
hey @jerryfan ! I'm in the process of rewriting the extension to decouple the process management from the ui in pi, so this or might become irrelevant in not too long. I'll keep it open for now and ping you when this refactor lands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps the process-control path English by default, but makes the highest-risk user-facing copy optionally localizable.
Why these strings:
killresults include terminate/failure/timeout guidance, where wording affects whether a user force-kills the right process.listoutput is the quick status surface for deciding what is still running, failed, or killed.What changed:
Validation:
npx tsc --noEmitpassednpx biome check --write src/i18n.ts src/index.ts src/tools/actions/kill.ts src/tools/actions/list.tspassednpx vitest runran; 4 passed, 14 failed on this Windows checkout because tests cannot resolve a shell executable for process-spawn testsIf useful later, I’m happy to handle broader localization in small follow-up PRs using whatever locale set you prefer.