fix: prevent crash on /new with running background processes#36
Merged
Conversation
Updated peer and dev Pi package versions from 0.69.0 to 0.72.1. No code migrations required; existing extension APIs remain compatible.
Bandaid fix for #35. The crash happens because session_shutdown kills all processes, their exit handlers fire pi.sendMessage() on the now-stale pi proxy, which throws. Wrap pi.sendMessage in safeSendMessage that catches stale-context errors so the extension doesn't crash during teardown. Processes are still killed on session shutdown — the fix just prevents the stale-proxy crash during that teardown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bandaid fix for #35.
Problem
Running
/newwhile background processes are active crashes pi:session_shutdownkills all processes, their exit handlers firepi.sendMessage()on the now-stalepiproxy, which throws.Fix
safeSendMessage()wrapspi.sendMessage()— catches stale-context errors instead of crashing. Processes are still killed on session shutdown as before. The fix just prevents the crash during teardown.Tradeoff
Process events that fire after the pi proxy is invalidated are silently dropped. This is acceptable for a bandaid — a full reattach solution will come with the extension rewrite.