docs(scrum-master-agent): add Network Access disclosure to SKILL.md#1051
Open
xiaolai wants to merge 1 commit into
Open
docs(scrum-master-agent): add Network Access disclosure to SKILL.md#1051xiaolai wants to merge 1 commit into
xiaolai wants to merge 1 commit into
Conversation
notify_channels.py makes outbound HTTPS POST requests to Slack/Teams webhook URLs when notifications are enabled. This was undisclosed in SKILL.md despite the outbound call being present in the implementation. Added a Network Access section under Limitations describing the opt-in nature, URL source (env vars/config, not user input), and default-off behavior. Co-Authored-By: Claude Code <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
notify_channels.pymakes outbound HTTPS POST requests to Slack/Teams webhook URLs when notifications are enabled, butSKILL.mdcontains no disclosure of this external network access —grep -r 'Network\|outbound\|external' generated-skills/scrum-master-agent/SKILL.mdreturns no hits for a dedicated disclosure.Evidence:
notify_channels.pyline 118:with urlopen(request, timeout=10) as response:and line 220 (same pattern) — confirmed outbound HTTP calls.SKILL.mdhas no### Network Accesssection or equivalent disclosure.Fix: Added
### Network Accesssubsection under## Limitationsdescribing the opt-in behavior, URL source (env vars/config — not user input), and that no network calls occur when notifications are not configured.