fix(commands): add missing YAML frontmatter to 9 unregistered slash commands#1052
Open
xiaolai wants to merge 7 commits into
Open
fix(commands): add missing YAML frontmatter to 9 unregistered slash commands#1052xiaolai wants to merge 7 commits into
xiaolai wants to merge 7 commits into
Conversation
…otection config Add comprehensive 2-week implementation plan for GitHub workflow automation: **Implementation Tracker** (.github/WORKFLOW_IMPLEMENTATION_TRACKER.md): - 2-week timeline with daily tasks (Nov 12-26) - Week 1: Foundation (branch protection, composite actions, PR validation) - Week 2: Commands (slash commands, auto-merge, documentation) - Progress tracking and success metrics - Team training plan **Branch Protection Config** (.github/BRANCH_PROTECTION_CONFIG.md): - Step-by-step GitHub Settings configuration - Protection rules for main and dev branches - Verification checklist and testing procedures - Emergency bypass procedures - Migration guide for existing branches **Workflow Adaptation Plan** (WORKFLOW_ADAPTATION_PLAN.md): - Complete analysis of blueprint repository - Current state vs. desired state comparison - 8 blueprint patterns to adopt - 4-phase implementation roadmap - Integration with existing workflows **Key Changes**: - Pushed dev branch to origin (new integration branch) - Created comprehensive implementation documentation - Ready for Phase 1: Branch protection and workflow setup **Next Steps**: 1. Apply branch protection rules in GitHub Settings 2. Clean up old branch names 3. Create composite actions 4. Begin workflow implementation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add concise step-by-step guide for applying branch protection rules: - 4-step process to configure branch protection - Set dev as default branch - Protect main and dev branches - Verification checklist - Common issues and solutions - 20-minute estimated completion time 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Day 2 of workflow implementation - create reusable composite actions: - fork-safety: Detects fork PRs and sets read-only permissions - quality-gates: Runs lint/typecheck/tests/YAML validation with graceful fallback - branch-cleanup: Auto-deletes merged branches with confirmation These actions follow DRY principle and will be used by multiple workflows. Updated implementation tracker to mark Day 1-2 as complete (18% progress). Related to workflow implementation plan (Nov 12-26, 2025) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…checks Day 3 of workflow implementation - create PR validation workflow: NEW FILE: .github/workflows/pr-into-dev.yml (464 lines) - Validates PRs targeting dev branch before merge - Fork safety check (read-only mode for fork PRs) - Branch naming validation (feature/, fix/, hotfix/, refactor/, test/, docs/) - PR title validation (conventional commits format) - Linked issue validation (requires at least one linked issue) - Quality gates (lint, type-check, tests, YAML validation) - Final status summary with detailed reporting MODIFIED: .github/workflows/ci-commit-branch-guard.yml - Added new branch naming convention (feature/ instead of feat/, etc.) - Maintained backward compatibility with old convention - Enhanced validation messages and guidance - Supports both old (feat/) and new (feature/) naming during transition This workflow ensures all PRs meet quality standards before merging to dev. Testing will be validated with first actual PR (deferred to Day 4). Updated tracker: 27% complete (Day 3 of 11) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…on gates Day 4 of workflow implementation - create production release workflow: NEW FILE: .github/workflows/dev-to-main.yml (568 lines) - Validates PRs targeting main branch (production releases) - Source branch validation (only dev or release/* allowed) - Rejects feature/* branches with helpful error message - Quality gates (stricter enforcement than dev) - Skills YAML validation (comprehensive check of all generated-skills/) - Security quick scan (adapted for skills repository): * Checks for hardcoded secrets/credentials in skills * Scans for AWS/GCP credentials * Detects debug print statements in Python skills * npm audit for dependency vulnerabilities - Deployment readiness checklist: * Version bump verification * Changelog update check * README updates * Skills count and quality metrics - Final release status with detailed gate results Skills Factory Specific Features: - YAML validation for all skill files - Security scan focused on generated-skills/ directory - No production build (not applicable for skills repo) - Pre-merge checklist tailored for skills releases This workflow ensures only thoroughly tested and validated releases reach the main branch. All production releases must pass stricter quality gates than development PRs. Testing will be validated with first dev → main PR (deferred). Updated tracker: 36% complete (Day 4 of 11) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Day 5 of workflow implementation - create automated branch workflow:
NEW FILE: .github/workflows/create-branch-on-issue.yml (492 lines)
- Automatically creates feature branches when issues are labeled
- Trigger: Issue labeled with both 'claude-code' AND 'status:ready'
- Smart branch naming: {type}/issue-{number}-{slug}
* Extracts issue number and title
* Creates URL-friendly slug (max 50 chars, lowercase, kebab-case)
* Detects type from labels (type:fix, type:hotfix, type:refactor, type:test, type:docs)
* Defaults to 'feature/' if no type label
* Example: feature/issue-42-add-aws-architect-skill
- Base branch customization:
* Default: creates from 'dev' branch
* Override: add 'base:main' label to create from main
* Fallback: uses 'main' if 'dev' doesn't exist
- Idempotency: skips if branch already exists (no errors)
- Issue status update: removes 'status:ready', adds 'status:in-progress'
- Helpful comment with:
* Branch checkout instructions
* Skills Factory specific development workflow
* Quality checklist for skills development
* PR creation guidance
* Conventional commit examples
- Workflow summary in GitHub UI with all details
Skills Factory Specific Features:
- Comment adapted for skills development workflow
- Quality checks focused on YAML validation and secrets
- Examples for adding skills to generated-skills/ directory
- Guidance on skill frontmatter and documentation
This workflow eliminates manual branch creation and ensures
consistent naming conventions. Developers can start working
immediately after labeling an issue.
Testing will be validated with first labeled issue (deferred).
Updated tracker: 45% complete (Day 5 of 11) - Week 1 Complete!
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Nine command files lacked the required YAML frontmatter block, preventing Claude Code from registering them as slash commands. Added `description:` field to each file following the existing repo convention. Affected commands: test-factory, codex-exec, factory-status, validate-output, install-hook, build, build-hook, sync-agents-md, install-skill. Co-Authored-By: Claude Code <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: Nine slash commands in
.claude/commands/lack a YAML frontmatter block — Claude Code requires adescription:field to register a command; without it, the command silently does not appear in the command palette and cannot be invoked.Evidence: Each file starts directly with a
# /command-nameprose heading;head -1 <file> | grep -c "^---"returns0for all nine files. Affected:test-factory,codex-exec,factory-status,validate-output,install-hook,build,build-hook,sync-agents-md,install-skill.Fix: Prepend a minimal
---\ndescription: <one-line summary>\n---block to each file, matching the style of the existing registered commands (e.g.,ci-guard.md,review.md).