Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update Scite dependency #524

Draft
wants to merge 3 commits into
base: beta
Choose a base branch
from

Conversation

alixlahuec
Copy link
Owner

@alixlahuec alixlahuec commented Jan 3, 2024

Description

Replace dependency on the scite-badge repo by the scite-extension repo, where badge-related code is now maintained.

FIXME:

  • Vite build fails because the Scite repo uses JSX syntax inside JS files. Tried a few different things, and managed to have them load as JSX, but the CSS imports the file contains are now failing

Copy link

linear bot commented Jan 3, 2024

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0af667c) 85.74% compared to head (78376e2) 85.35%.

❗ Current head 78376e2 differs from pull request most recent head 6c51ee7. Consider uploading reports for the commit 6c51ee7 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             beta     #524      +/-   ##
==========================================
- Coverage   85.74%   85.35%   -0.39%     
==========================================
  Files         162      160       -2     
  Lines        5000     5017      +17     
  Branches     1310     1328      +18     
==========================================
- Hits         4287     4282       -5     
- Misses        711      733      +22     
  Partials        2        2              

see 7 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant