Skip to content

fix(a2a): localize permission identity errors #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guima-why merged 1 commit into from
Aug 31, 2026
Merged

fix(a2a): localize permission identity errors #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/iac_code/a2a/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1262,6 +1262,7 @@ async def _execute(self, context: RequestContext, event_queue: EventQueue, *, co
response=permission_response,
code=exc.code,
retryable=exc.retryable,
language=self._resolve_preferred_language(response_metadata),
)
return
except InvalidParamsError:
Expand Down Expand Up @@ -2273,6 +2274,7 @@ def make_pipeline_executor() -> IacCodeA2APipelineExecutor:
response=response,
code="legacy_permission_identity",
retryable=False,
language=preferred_language,
session_id=context_record.session_id,
)
return True
Expand All @@ -2290,6 +2292,7 @@ def make_pipeline_executor() -> IacCodeA2APipelineExecutor:
response=response,
code=exc.reason,
retryable=exc.retryable,
language=preferred_language,
session_id=context_record.session_id,
)
return True
Expand All @@ -2303,6 +2306,7 @@ def make_pipeline_executor() -> IacCodeA2APipelineExecutor:
response=response,
code="cloud_execution_identity_changed",
retryable=False,
language=preferred_language,
session_id=context_record.session_id,
)
return True
Expand Down Expand Up @@ -2648,14 +2652,15 @@ async def _publish_permission_identity_error(
response: PermissionResponse,
code: str,
retryable: bool,
language: str | None = None,
session_id: str | None = None,
) -> None:
await self._publish_status(
event_queue,
task_id=response.task_id,
context_id=response.context_id,
state=TaskState.TASK_STATE_INPUT_REQUIRED,
text=_("A temporary error occurred. Please retry."),
text=translate_message("A temporary error occurred. Please retry.", language=language or "en"),
metadata={
"iac_code": {
"permissionIdentityError": {
Expand Down
7 changes: 6 additions & 1 deletion tests/a2a/test_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4720,13 +4720,18 @@ async def publish(_queue, **kwargs):
monkeypatch.setattr(executor, "_publish_status", publish)

await executor._execute(
FakeRequestContext(task_id="task-1", context_id="ctx-1"),
FakeRequestContext(
task_id="task-1",
context_id="ctx-1",
metadata={"iac_code": {"preferredLanguage": "zh-CN"}},
),
FakeEventQueue(),
context_id="ctx-1",
)

assert len(published) == 1
assert published[0]["state"] == TaskState.TASK_STATE_INPUT_REQUIRED
assert published[0]["text"] == "发生临时错误，请重试。"
error = published[0]["metadata"]["iac_code"]["permissionIdentityError"]
assert error == {
"code": "InternalError",
Expand Down
Loading