Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add network parameter for session #24

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Conversation

pitt-liang
Copy link
Collaborator

@pitt-liang pitt-liang commented Jun 7, 2024

  • add network parameter for session.
  • support get default network from environment variable.
  • inspect network type if network is not specified.

@pitt-liang pitt-liang force-pushed the dev/default_network branch 2 times, most recently from bdd0752 to 8a341fd Compare June 11, 2024 05:44
pai/toolkit/helper/utils.py Show resolved Hide resolved
pai/session.py Show resolved Hide resolved
pai/api/client_factory.py Show resolved Hide resolved
Copy link
Contributor

@firgavin firgavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pitt-liang pitt-liang merged commit a2052ef into master Jun 11, 2024
4 checks passed
@pitt-liang pitt-liang deleted the dev/default_network branch June 11, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants