Multiple galleries on one page fix.#26
Open
PeterSchmiedt wants to merge 1 commit intoalkacon:branch_9_0_xfrom
Open
Multiple galleries on one page fix.#26PeterSchmiedt wants to merge 1 commit intoalkacon:branch_9_0_xfrom
PeterSchmiedt wants to merge 1 commit intoalkacon:branch_9_0_xfrom
Conversation
I was having trouble when I had 2 or more galleries on one page. When I tried to view the last image of the first gallery and then "loop over" to the first image, I got to the first image but from the second gallery.
After reading the official documentation of colorbox, I found out that the most simple initialization of colorbox should be:
"$(".group1").colorbox({rel: 'group1'});
As you can see the "rel" attribute is missing, so I added the missing attribute.
Also as you can see there isn't an "a" before the ".group1" so I removed that.
This fixed my problem.
I don't know if that removal of the "a" has any impact on this fix, but I omitted it just to be sure.
Peter Schmiedt
NELASOFT Technologies, s.r.o.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having trouble when I had 2 or more galleries on one page. When I tried to view the last image of the first gallery and then "loop over" to the first image, I got to the first image but from the second gallery.
After reading the official documentation of colorbox, I found out that the most simple initialization of colorbox should be:
"$(".group1").colorbox({rel: 'group1'});
As you can see the "rel" attribute is missing, so I added the missing attribute.
Also as you can see there isn't an "a" before the ".group1" so I removed that.
This fixed my problem.
I don't know if that removal of the "a" has any impact on this fix, but I omitted it just to be sure.
Peter Schmiedt
NELASOFT Technologies, s.r.o.