Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #387 - prevent JGit from accessing system config to support Gradle configuration cache #683

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

SmialyKot
Copy link
Contributor

As described in the issue - JGit is accessing system config file, which breaks Gradle configuration cache. In order to disable this feature in JGit, we need to supply a new SystemReader without this functionality before initializing JGit repository. This new SystemReader delegates all responsibilities to the original reader, with the exception of loading system config, which is replaced with an empty implementation to prevent access.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f63f2cb) 60.66% compared to head (72d5272) 60.95%.

Files Patch % Lines
...structure/git/SystemReaderWithoutSystemConfig.java 92.30% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #683      +/-   ##
============================================
+ Coverage     60.66%   60.95%   +0.29%     
- Complexity      388      398      +10     
============================================
  Files            81       82       +1     
  Lines          1538     1552      +14     
  Branches        146      146              
============================================
+ Hits            933      946      +13     
- Misses          535      536       +1     
  Partials         70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgalek bgalek merged commit d60d084 into allegro:main Nov 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants