Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type definitions: Mention, SymbolData, and PaperData #27

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

carolinepaulic
Copy link
Contributor

DRAFT: Don't merge until #26 has been merged.

Description

This covers the Mentions subtask of https://github.com/allenai/scholar/issues/28339

Changes in this PR:

  • New types for Mention, SymbolData, and PaperData based on example API response

Testing Plan

  • Ran all unit tests

@carolinepaulic carolinepaulic changed the base branch from cp/28339-subtask_model-definitions-entity-bounding-box to main September 1, 2021 02:38
@carolinepaulic carolinepaulic changed the title Added type definition for Mention, SymbolData, and PaperData Type definitions: Mention, SymbolData, and PaperData Sep 1, 2021
@smitar smitar removed their request for review November 16, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant