Skip to content

Conversation

favyen2
Copy link
Collaborator

@favyen2 favyen2 commented Oct 18, 2024

A code archive is created when launching Beaker job so you don't need to build new image when you're just making a new config file and potentially some supporting training code.

This updates it so sensitive files as well as potentially large stuff are excluded.

@favyen2
Copy link
Collaborator Author

favyen2 commented Oct 18, 2024

Would it be better to include the model config only by default, which can be supplemented with a set of user-specified paths?

Also, for the Beaker image, should we always leave that as a parameter and expect each user to make their own image (because one might update stuff in rslearn / add new dependency that requires image update)?

@favyen2 favyen2 requested a review from yawenzzzz October 22, 2024 02:18
Copy link
Collaborator

@yawenzzzz yawenzzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@favyen2 favyen2 merged commit e509899 into master Oct 22, 2024
4 checks passed
@favyen2 favyen2 deleted the favyen/issue1 branch October 22, 2024 17:40
yawenzzzz pushed a commit that referenced this pull request Jul 3, 2025
Ignore files when creating code archive to launch Beaker job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants