Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add firefox support using storage.local #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add firefox support using storage.local #39

wants to merge 1 commit into from

Conversation

kneekill
Copy link

  • add ./prioritab-firefox-bundle with edits (chrome.storage.sync -> chrome.storage.local) to prioritab.min.js and lib/sortaeditalist.js to support Firefox

Firefox 57 does not currently support chrome/browser.storage.sync, I would've made changes directly to ./prioritab-bundle but the change to storage.local reduces functionality.

Also, can I post this extension on the Firefox add-on store? I'm switching over to Firefox and would like to continue using this extension and I'm sure there are others in a similar situation.

@allenjhyang
Copy link
Owner

Hey kneekill,

Thanks for contributing, and glad to hear you find this extension useful!

General caveat: I'm not actively maintaining this project anymore.

Some initial reactions to your PR:

  • Is the best way to do this by creating a bundle folder that duplicates so many files? Concerned that if somebody changes something in the original project, the changes aren't going to reflect in the Firefox version automatically
  • What needs to change with the Chrome version to make it work with Firefox?
  • I don't mind at all if you publish a version to the Firefox store; please just have a pointer to the Chrome version and this Github repo?

@kneekill
Copy link
Author

Hey!

First of all, sorry for the late response, I somehow missed this when you replied.

You're absolutely right about the duplication of files. It seems that I didn't really think things through when I made this PR. I suppose I got a little over eager with my first PR to an open-source project!

In any case, I just did some quick research and chrome.storage.sync has been supported in Firefox since version 53 with the inclusion of the Firefox application id in the manifest.json D'oh!

If you still don't mind, I can make the manifest.json change, merge and then submit it to the Firefox add-on store with the relevant credit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants