Make event_status and current_version optional on gene change events#326
Conversation
Override required: false via slot_usage on both GeneChangeEventSlotAnnotation and GeneChangeEventSlotAnnotationDTO (event_status_name / current_version). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Summary: Follow-up to #323. Relaxes Assertions: None. The change is mechanically correct and consistent:
Questions (judgment calls for curators):
Otherwise this looks good — surgical and following the established |
Per follow-up review, apply the required: false override on the abstract ChangeEventSlotAnnotation and ChangeEventSlotAnnotationDTO classes via slot_usage, rather than on the gene-specific child classes. Removes the now-redundant overrides from GeneChangeEventSlotAnnotation and GeneChangeEventSlotAnnotationDTO. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Sorry, meant to make these changes on the parent classes, not just the gene-specific children. Now fixed as per 14f9ee0 |
chris-grove
left a comment
There was a problem hiding this comment.
I also went ahead and removed the slot requirements at the level of the slot definitions, which is required in this case as we cannot override requirements for slots in slot_usage if they are defined as required in the slot definitions. I've made those changes and all tests pass so I'm approving this PR
Summary
required: falseviaslot_usageon bothGeneChangeEventSlotAnnotationandGeneChangeEventSlotAnnotationDTOforevent_status/event_status_nameandcurrent_version.required: trueon the abstractChangeEventSlotAnnotation/ChangeEventSlotAnnotationDTOparents — only the gene subclass relaxes them.Test plan
check-pull-request.yaml) regenerates artifacts and runs the full test suite🤖 Generated with Claude Code