Fixed scale issue in conversion function #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unding issues Signed-off-by: willem.romijn <[email protected]>
WillemRomijn-werk
force-pushed
the
fix-for-scale-error-in-conversion
branch
from
a041f98 to
f69b582
Compare
BaukjeD
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed a bug where unit conversion used the wrong scale, leading to rounding issues:
val energyInJoule = 13500000 * joule
val valueInKwh = energyInJoule
inkiloWattHourwould result in 3.8 kwh instead of the expected 3.75 kwh