Optimize include stmts, Fix IDE warnings and typos #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great — merged. Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly does the following things:
#include <xxx.h>statements and adds back the needed onesThe commits are split into small steps. Please let me know if any should be broken down further.
And this could be done through several PRs if it's more convenient for you. (Please advise on how to break it down.)
The code has been tested on my Ubuntu 22.04 and macOS environments, but I cannot guarantee about the edge cases (e.g.,
-Dmarcos).BTW, thanks for the quick mail reply 5 weeks ago! 😍
We are still working on the parallelize problem, hope we can bring the result soon.