feat(provider): eth_getLogs with batch and count options

[wetkeyboard]

Ref foundry-rs/foundry#11638 (review)

[graphite-app]

Integer overflow vulnerability: batch_end + 1 can overflow when batch_end is u64::MAX. This will cause a panic in debug mode or wraparound to 0 in release mode, potentially creating an infinite loop. Fix: Add overflow check before incrementing: if batch_end == u64::MAX { break; } batch_start = batch_end + 1;

Suggested change

	batch_start = batch_end + 1;
	if batch_end == u64::MAX { break; }
	batch_start = batch_end + 1;

Spotted by Diamond



Is this helpful? React 👍 or 👎 to let us know.

[mattsse]

not opposed to this, but let's try this as a dedicated future type instead

[wetkeyboard]

Updated, please take another look @mattsse , now the usage like below:

  // Simple log retrieval (unchanged)
  let logs = provider.get_logs(&filter).await?;

  // New enhanced API with batch support
  // Basic usage (equivalent to get_logs)
  let logs = provider.logs(filter).await?;

  // With batching (fetch logs in chunks of 1000 blocks)
  let logs = provider.logs(filter).with_batch_size(1000).await?;

  // With count limit (stop after 500 logs)
  let logs = provider.logs(filter).with_max_count(500).await?;

  // Combined options
  let logs = provider.logs(filter)
      .with_batch_size(1000)
      .with_max_count(500)
      .await?;

[mattsse]

ty, all of this looks fine

need some time to properly review this

[graphite-app]

The attribute should be #[allow(clippy::unnameable_types)] or #[expect(clippy::unnameable_types)] with the full clippy namespace specified. The current form #[expect(unnameable_types)] is incorrect and won't properly suppress the lint warning.

Suggested change

	#[expect(unnameable_types)]
	#[expect(clippy::unnameable_types)]

Spotted by Diamond



Is this helpful? React 👍 or 👎 to let us know.

[0xferrous]

can we get this going again?