Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dyn-abi): support parse scientific number #835

Merged
merged 7 commits into from
Jan 1, 2025

Conversation

9547
Copy link
Contributor

@9547 9547 commented Dec 31, 2024

Motivation

implement and close #816

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style suggestion,

not familiar with the winnow api

crates/dyn-abi/src/coerce.rs Outdated Show resolved Hide resolved
Signed-off-by: 9547 <[email protected]>
crates/dyn-abi/src/coerce.rs Outdated Show resolved Hide resolved
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DaniPopes DaniPopes enabled auto-merge (squash) January 1, 2025 14:03
@DaniPopes DaniPopes merged commit d3e73c4 into alloy-rs:main Jan 1, 2025
30 checks passed
@9547 9547 deleted the int-scientific branch January 2, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support parsing numbers with scientific notation
3 participants