feat: add trie root fns for exact sized iter #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
DaniPopes,
gakonst and
rkrasiuk
as code owners
DaniPopes
reviewed
Dec 11, 2024
| let index = adjust_index_for_rlp(i, items_len); | ||
|
|
||
| let index_buffer = alloy_rlp::encode_fixed_size(&index); | ||
|
|
||
| value_buffer.clear(); | ||
| encode(&items[index], &mut value_buffer); | ||
| encode(item, &mut value_buffer); |
There was a problem hiding this comment.
oh right this is why it doesn't work, it doesn't encode in order
|
cc @rkrasiuk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for receipts we usually have the case where we have
Vec<Receipt>but we needReceiptWithBloom<Receipt>to calculate the trie rootit would be beneficial to use an iterator for these cases and avoid the collect in
map(ReceiptWithBloom).collect