This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Fix mouse offset when parent has position:relative #4166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://caniuse.com/#feat=getboundingclientrect, IE and Edge don't have x and y values.
|
The timeline is no longer maintained here. Please resubmit this PR to the new maintained repo: |
16 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue when parent has
position: relative.offsetLeftis offset from the nearest relatively positioned parent, so a relative parent that has any sort of left offset will cause the mouse position to be wrong. This issue isn't noticeable in most cases because it's taking the difference between the time you start dragging at and the current time under the mouse, and most timelines are linear. It does cause issues with non-linear timelines though, such as when some periods are hidden.JSFiddle
Examples
Old code with left margin
Fixed code with left margin
Old code with scroll
Fixed code with scroll