Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste Error Bugfix #1080

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

ggalileo
Copy link
Contributor

@ggalileo ggalileo commented Feb 6, 2014

This pull request adds an exception handler for the paste() call and only write to console.error if it exists.

This code has been tested across browsers by our QE.

  1. obey coding guidelines
  2. write JSLint compliant code
  3. write JSDoc for every method you touched during your implementation
  4. write a human-readable :) Changelog entry that describes your change
  5. add a qunit test (if it makes sense) and/or document the steps to manually test it (in a separate guides page)
  6. test your changes in Internet Explorer 7, 8, 9 and the latest Firefox and latest Chrome
  7. document your changes in a guides page
  8. include this list in a your pull request

@Jotschi
Copy link
Contributor

Jotschi commented Feb 7, 2014

Code looks good. Changelog should be "paste-plugin:" and not "Paste Plugin". I think we can deal with that during releasing.

@GenticsDev
Copy link
Contributor

Can one of the admins verify this patch?

@Jotschi
Copy link
Contributor

Jotschi commented Feb 19, 2014

Admin please build this request

@GenticsDev
Copy link
Contributor

Test FAILed.
Refer to this link for build results: http://jenkins.office:8080/job/alohaeditor-upstream-pullrequests/6/

@Jotschi
Copy link
Contributor

Jotschi commented Feb 19, 2014

Admin please build this request

@GenticsDev
Copy link
Contributor

Test PASSed.
Refer to this link for build results: http://jenkins.office:8080/job/alohaeditor-upstream-pullrequests/15/

@petrosalema
Copy link
Member

@ggalileo what exceptions are raised during paste? Are you catching exceptions in the event that <script> elements are pasted into the content?

@ggalileo
Copy link
Contributor Author

ggalileo commented Mar 4, 2014

The errors from the bug report in the defect said that these two errors were seen in IE

  • SCRIPT5022: DOMException: INDEX_SIZE_ERR
  • Error: Access is denied

The actual pasted content was not included in the defect. Unfortunately, the developer who made this fix is no longer with us.

@GenticsDev
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@GenticsDev
Copy link
Contributor

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants